dot3 Stats collection #3615
Merged
dot3 Stats collection #3615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 17, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Jun 2, 2025
Collaborator
|
@bhouse-nexthop , just want to confirm this will not have an impact if the underlying h/w implementation does not support the counters, right? |
RFC1284 defines dot3 stats that most switch vendors support. This RFC was superceded by RFC3635 which includes 64bit "HC" counters. We need to collect these statistics for use by sonic_snmpagent. Signed-off-by: Brad House <[email protected]>
bhouse-nexthop
force-pushed
the
bhouse-nexthop/dot3stats
branch
from
1eb2daa to
7a48ee4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@prsunny somehow I missed your reply on this. Correct, I've tested it on Broadcom TH5 which currently isn't outputting these in their SAI implementation and it doesn't break anything. However on Mellanox/Nvidia the stats are output correctly. I just rebased this PR in order to fix the merge conflicts. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement RFC3635 dot3 statistics collection.
Used by sonic-net/sonic-snmpagent#350
Fixes sonic-net/sonic-buildimage#22359
Why I did it
RFC1284 defines dot3 stats that most switch vendors support. This RFC was superseded by RFC3635 which includes 64bit "HC" counters. We need to collect these statistics for use by sonic_snmpagent.
How I verified it
Tested on Mellanox SN2201 physical hardware, where dot3 stats are implemented by the SAI.
Details if related
The Broadcom SAI does not currently implement these statistics. A case has been raised with Broadcom to implement these stats.