Fixed: Kdump Remote Patch #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tests/sonic_kdump_config_test.py
Outdated
| import unittest | ||
| from unittest.mock import patch, mock_open, Mock | ||
| from utilities_common.general import load_module_from_source | ||
| from /home/ali/Desktop/sonic-kdump-8th-aprail-2025/sonic-utilities/scripts/sonic-kdump-config import main |
Contributor
There was a problem hiding this comment.
Please fix this import.
tests/sonic_kdump_config_test.py
Outdated
| return_result = sonic_kdump_config.get_next_image() | ||
| self.assertEqual(sys_exit.exception.code, 1) | ||
|
|
||
| # @patch('os.geteuid') |
Contributor
There was a problem hiding this comment.
Please uncomment the test cases.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scripts/sonic-kdump-config
Outdated
| help='Maximum number of kernel dump files stored') | ||
|
|
||
| parser.add_argument('--remote', action='store_true', default=False, | ||
| help='ssh_string for remote kdump') |
Contributor
There was a problem hiding this comment.
Please fix the help string. This string is the same as the help string for the option "-ssh_string" added below.
Contributor
|
lgtm. Please resolve all @prabhataravind 's comments. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
approved these changes
Apr 14, 2025
Contributor
prabhataravind
left a comment
prabhataravind
left a comment
There was a problem hiding this comment.
The latest diff lgtm
Contributor
|
@qiluo-msft please help merge. |
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
Link to all PRs of the KDUMP = KDUMP SONiC HLD PRs
Related sonic-utilities: Fixing remote feature build failure
Issue: There was a build failure for the remote variable in kdump-sonic-utilities PR
Following were to be addressed, which are ADDRESSED in this PR
```
E 2025 Apr 1 04:56:08.321576 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--disable'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:09.638838 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--memory', '0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:11.199498 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--num_dumps', '3'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:13.969595 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--remote', 'false'] - failed: return code - 2, output:#012None
E 2025 Apr 1 04:56:16.373762 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--ssh_string', 'user@localhost'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:17.579657 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--ssh_path', '/a/b/c'] - failed: return code - 1, output:#012None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to all PRs of the KDUMP = KDUMP SONiC HLD PRs
Related sonic-utilities: Fixing remote feature build failure
Issue: There was a build failure for the remote variable in kdump-sonic-utilities PR
Following were to be addressed, which are ADDRESSED in this PR