-
Notifications
You must be signed in to change notification settings - Fork 753
Fixed: Kdump Remote Patch #3835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
qiluo-msft
merged 73 commits into
sonic-net:master
from
muhammadalihussnain:remote-patch
Apr 14, 2025
Merged
Changes from 8 commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
a9a8800
fixed remote variable patch
muhammadalihussnain e9d98cd
fixed remote variable patch
muhammadalihussnain 7671a03
covering coverage
muhammadalihussnain 8fbc889
covering coverage
muhammadalihussnain 3c3f08c
covering coverage
muhammadalihussnain ed763ae
covering coverage
muhammadalihussnain 13106bb
covering coverage
muhammadalihussnain 61ed07a
covering coverage
muhammadalihussnain 7517c40
covering coverage
muhammadalihussnain 2c12467
covering coverage
muhammadalihussnain 26d1db9
covering coverage
muhammadalihussnain 6f4422a
covering coverage
muhammadalihussnain cb68255
covering coverage
muhammadalihussnain 5b45ff8
code coverage
muhammadalihussnain c9fba44
reverted unintended changes
muhammadalihussnain 33a6b10
added test case
muhammadalihussnain 049281b
added test case
muhammadalihussnain 4510400
added test case
muhammadalihussnain 6f9ff7d
added test case
muhammadalihussnain 8e2e4cc
added test case
muhammadalihussnain 41b8e8c
added test case
muhammadalihussnain 2aabc2b
added test case
muhammadalihussnain 493f958
added test case
muhammadalihussnain 94f305a
added test case
muhammadalihussnain 1811eaf
added test case
muhammadalihussnain 9f4b5fc
added test case
muhammadalihussnain 5fd1255
added test case
muhammadalihussnain fe38f53
code coverage
muhammadalihussnain 86bc1ce
code coverage
muhammadalihussnain c5945e0
code coverage
muhammadalihussnain eb0fb92
code coverage
muhammadalihussnain b215ae6
code coverage
muhammadalihussnain 0a2f98e
code coverage
muhammadalihussnain 0d4c389
code coverage
muhammadalihussnain a999fe8
code cover
muhammadalihussnain c8de38b
code cover
muhammadalihussnain 31f4b9f
code cover
muhammadalihussnain 08b5ff1
code cover
muhammadalihussnain 16b4b9c
code cover
muhammadalihussnain 33bb0dd
code cover
muhammadalihussnain d996bbf
code cover
muhammadalihussnain 19a0dde
coverage
muhammadalihussnain 0a8a873
coverage
muhammadalihussnain ae98d8b
coverage
muhammadalihussnain 523ce60
coverage
muhammadalihussnain 535b346
cover
muhammadalihussnain be92dc6
cover
muhammadalihussnain ddb368b
cover
muhammadalihussnain b43e4fb
cover
muhammadalihussnain 041ec66
cover
muhammadalihussnain 173408f
cover
muhammadalihussnain 421df2a
cover
muhammadalihussnain 2bf29e4
cover
muhammadalihussnain 8fc6be2
cover
muhammadalihussnain 5301e38
coverage
muhammadalihussnain 43f8f6f
coverage
muhammadalihussnain 7f7de4c
coverage
muhammadalihussnain 2f2049f
coverage
muhammadalihussnain c6338f7
coverage
muhammadalihussnain 45bc7d1
coverage
muhammadalihussnain 04dc9b0
coverage
muhammadalihussnain 486eafd
coverage
muhammadalihussnain c3048b5
coverage
muhammadalihussnain 47c494a
coverage
muhammadalihussnain 4f574fe
coverage
muhammadalihussnain fad09b1
cover
muhammadalihussnain 8359eed
cover
muhammadalihussnain dcfdb5d
cover
muhammadalihussnain c5bf74a
coverage
muhammadalihussnain c4fb126
coverage
muhammadalihussnain a08e5b8
coverage
muhammadalihussnain e159e84
fixed helping string
muhammadalihussnain 4414864
fixed helping string
muhammadalihussnain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| import unittest | ||
| from unittest.mock import patch, mock_open, Mock | ||
| from utilities_common.general import load_module_from_source | ||
| from /home/ali/Desktop/sonic-kdump-8th-aprail-2025/sonic-utilities/scripts/sonic-kdump-config import main | ||
|
|
||
| from sonic_installer.common import IMAGE_PREFIX | ||
|
|
||
|
|
@@ -328,6 +329,24 @@ def test_get_image(self, mock_get_bootloader): | |
| return_result = sonic_kdump_config.get_next_image() | ||
| self.assertEqual(sys_exit.exception.code, 1) | ||
|
|
||
| # @patch('os.geteuid') | ||
|
||
| # @patch('sonic_kdump_config.cmd_kdump_remote') | ||
| # def test_cmd_remote(self, mock_cmd_kdump_remote, mock_geteuid): | ||
| # """Tests the function `cmd_kdump_remote(...)` in script `sonic-kdump-config`. | ||
| # """ | ||
| # # Mock the output of cmd_kdump_remote | ||
| # mock_cmd_kdump_remote.return_value = None # Assuming the function prints directly | ||
|
|
||
| # # Mock os.geteuid to return 0 (root user) | ||
| # mock_geteuid.return_value = 0 | ||
|
|
||
| # # Call the function with the --remote argument | ||
| # with patch('sys.argv', ['sonic-kdump-config', '--remote']): | ||
| # main() | ||
|
|
||
| # # Verify that cmd_kdump_remote was called | ||
| # mock_cmd_kdump_remote.assert_called_once() | ||
|
|
||
| @patch("sonic_kdump_config.run_command") | ||
| @patch("sonic_kdump_config.get_kdump_remote") | ||
| def test_write_kdump_remote_true(self, mock_read_remote, mock_run_command): | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this import.