-
Notifications
You must be signed in to change notification settings - Fork 775
Display only external ports on single-asic systems by default #4140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arista-nwolfe
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
arista-nwolfe:master-single-asic-display-external-only
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Display only external ports on single-asic systems by default #4140
arista-nwolfe
wants to merge
1
commit into
sonic-net:master
from
arista-nwolfe:master-single-asic-display-external-only
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the behavior of multi-asic and single-asic to only display external ports by default. This will fix certain sonic-mgmt tests on single-asic systems with internal ports that don't expect them to be there. See sonic-net/sonic-mgmt#18249
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mlok-nokia
approved these changes
Jan 14, 2026
Contributor
mlok-nokia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
Author
|
/azpw run Azure.sonic-utilities |
Collaborator
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the behavior of multi-asic and single-asic to only display external ports by default.
This will fix certain sonic-mgmt tests on single-asic systems with internal ports that don't expect them to be there.
See sonic-net/sonic-mgmt#18249
Without this sonic-mgmt function calls like:
duthost.show_interface(command="status", include_internal_intfs=False)['ansible_facts']['int_status']Would return internal ports on single-asic systems despite being passed
include_internal_intfs=FalseWithout this change
qos/test_pfc_counters.pyfails on single-asic UT2 systems with:With this change the test passes.