Skip to content

Display only external ports on single-asic systems by default #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arista-nwolfe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Display only external ports on single-asic systems by default #4140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions utilities_common/multi_asic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,9 @@ def skip_display(self, object_type, cli_object):
'''
The function determines if the passed cli_object has to be displayed or not.
returns true if the display_option is external and the cli object is internal.
returns false, if the cli option is all or if it the platform is single ASIC.
returns false, if the cli option is all.

'''
if not self.is_multi_asic and not device_info.is_chassis():
return False
if self.get_display_option() == constants.DISPLAY_ALL:
return False
return self.is_object_internal(object_type, cli_object)
Expand Down Expand Up @@ -87,10 +85,7 @@ def multi_asic_display_choices():


def multi_asic_display_default_option():
if not multi_asic.is_multi_asic() and not device_info.is_chassis():
return constants.DISPLAY_ALL
else:
return constants.DISPLAY_EXTERNAL
return constants.DISPLAY_EXTERNAL


_multi_asic_click_option_display = click.option('--display',
Expand Down
Loading