feat(deps): angular version upgrade and converted into workspace#65
Merged
yeshamavani merged 3 commits intomasterfrom Dec 30, 2025
Merged
feat(deps): angular version upgrade and converted into workspace#65yeshamavani merged 3 commits intomasterfrom
yeshamavani merged 3 commits intomasterfrom
Conversation
vaibhavbhalla2505
force-pushed
the
GH-64
branch
13 times, most recently
from
6eaffda to
6282517
Compare
angular version upgrade and converted into workspace BREAKING CHANGE: YES GH-64
vaibhavbhalla2505
force-pushed
the
GH-64
branch
3 times, most recently
from
22a7b7b to
3d98448
Compare
vaibhavbhalla2505
force-pushed
the
GH-64
branch
4 times, most recently
from
20ebc25 to
b384a4b
Compare
yeshamavani
requested changes
Dec 30, 2025
Contributor
There was a problem hiding this comment.
add all the 4 packages here
Comment on lines
+106
to
+115
| "main": "projects/search-lib/src/test.ts", | ||
| "polyfills": "projects/search-lib/src/polyfills.ts", | ||
| "tsConfig": "projects/search-lib/tsconfig.spec.json", | ||
| "karmaConfig": "projects/search-lib/karma.conf.js", | ||
| "inlineStyleLanguage": "scss", | ||
| "assets": [ | ||
| "projects/search-element/src/favicon.ico", | ||
| "projects/search-element/src/assets" | ||
| "projects/search-lib/src/favicon.ico", | ||
| "projects/search-lib/src/assets" | ||
| ], | ||
| "styles": ["projects/search-element/src/styles.scss"], | ||
| "styles": ["projects/search-lib/src/styles.scss"], |
| "prepublishOnly": "npm run build", | ||
| "pretest": "npm run build", | ||
| "test": "echo \"No tests available !\"" | ||
| "test": "ng test" |
Contributor
There was a problem hiding this comment.
have you updated test cases ?
Contributor
Author
There was a problem hiding this comment.
Yes, the lines of code changed after introducing signals.
| "@angular/platform-browser": "^21.0.0", | ||
| "@angular/platform-browser-dynamic": "^21.0.0", | ||
| "@angular/router": "^21.0.0", | ||
| "@sourceloop/user-onboarding-client": "file:../../packages/user-onboarding/projects/user-onboarding-lib/dist/sourceloop-user-onboarding-client-6.0.0.tgz", |
Contributor
There was a problem hiding this comment.
make sure to update later
vaibhavbhalla2505
force-pushed
the
GH-64
branch
5 times, most recently
from
51aed78 to
ed245cf
Compare
vaibhavbhalla2505
force-pushed
the
GH-64
branch
2 times, most recently
from
c126f3e to
ea4a577
Compare
changes in angular.json GH-64
vaibhavbhalla2505
force-pushed
the
GH-64
branch
from
ea4a577 to
bede705
Compare
yeshamavani
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
YES
Description
This pull request introduces significant refactoring and modernization of the
SearchComponentin thesearch-libpackage, focusing on adopting Angular's new signal-based inputs/outputs, streamlining configuration management, and improving testability. Additionally, it includes workspace and dependency updates at the root level, and some cleanup of outdated scripts and files.Fixes #64
Type of change
Please delete options that are not relevant.
Checklist: