-
Notifications
You must be signed in to change notification settings - Fork 72
oauth: Add documentation on OAuth integrations and M2M credentials #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes SRC-1356. Test plan: Review.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
||
<Accordion title="Authorization Code Flow (Private Clients)"> | ||
|
||
1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint: | |
1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint (line breaks for better illustration): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think someone who we want to trust to implement OAuth correctly will not understand that? 😬
|
||
The user may be asked for consent to grant your app the requested scopes if not previously granted. | ||
|
||
2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter: | |
2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter (line breaks for better illustration): |
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
Closes SRC-1356.
Test plan: Review.