Skip to content

Conversation

eseliger
Copy link
Member

Closes SRC-1356.

Test plan: Review.

Copy link

vercel bot commented Aug 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sourcegraph-docs Ready Ready Preview Comment Aug 15, 2025 4:13pm

Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


<Accordion title="Authorization Code Flow (Private Clients)">

1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint:
1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint (line breaks for better illustration):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think someone who we want to trust to implement OAuth correctly will not understand that? 😬


The user may be asked for consent to grant your app the requested scopes if not previously granted.

2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter:
2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter (line breaks for better illustration):

eseliger and others added 2 commits August 15, 2025 17:56
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
@eseliger eseliger merged commit cb15edb into main Aug 18, 2025
5 checks passed
@eseliger eseliger deleted the es/oauth branch August 18, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants