Support enclosing ranges for function definitions #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
podtserkovskiy
force-pushed
the
enclosing_ranges_for_functions
branch
from
94e8caa to
cbe47ef
Compare
Contributor
Author
|
@jupblb This PR is now ready for the review. However, I use pre-release version of |
Member
|
I've created sourcegraph/scip#344, awaiting review |
podtserkovskiy
force-pushed
the
enclosing_ranges_for_functions
branch
from
cbe47ef to
ca009fe
Compare
Contributor
Author
|
I upgraded |
podtserkovskiy
force-pushed
the
enclosing_ranges_for_functions
branch
from
ca009fe to
a8c1677
Compare
jupblb
suggested changes
Nov 7, 2025
Member
jupblb
left a comment
jupblb
left a comment
There was a problem hiding this comment.
Overall LGTM! Thank you so much for this contribution!! 🎉 Please take a look at two minor comments, I'll try to review further changes ASAP. 😃
podtserkovskiy
force-pushed
the
enclosing_ranges_for_functions
branch
from
a8c1677 to
ad6ac1b
Compare
Contributor
Author
|
I've just applied your suggestions. Sorry for the late reaction, I was traveling 😀 |
Contributor
Author
|
Thanks for the review&merge ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported
enclosing_rangefor function definitions only.Introducing additional traversal with
ast.PreorderStack, becauseast.Walkdoesn't allow to access information about enclosing nodes.The implementation code would be a bit simpler if
ast.PreorderStackbe used for the main traversal.For #92