Support enclosing ranges for Go snapshots #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
jupblb
requested changes
Oct 10, 2025
podtserkovskiy
force-pushed
the
go_snapshots_enclosing_ranges
branch
from
ca16b16 to
a075e78
Compare
podtserkovskiy
force-pushed
the
go_snapshots_enclosing_ranges
branch
from
a075e78 to
19ba735
Compare
jupblb
approved these changes
Oct 10, 2025
| } | ||
| enclosingRanges := enclosingRanges(document.Occurrences) | ||
| enclosingByStartLine := enclosingRangesByStartLine(enclosingRanges) | ||
| for _, ers := range enclosingByStartLine { |
There was a problem hiding this comment.
Nit: I'd prefer to get already sorted output from enclosingRangesBy...Line.
| }) | ||
| } | ||
| enclosingByEndLine := enclosingRangesByEndLine(enclosingRanges) | ||
| for _, ers := range enclosingByStartLine { |
There was a problem hiding this comment.
range enclosingByEndLine (but please move this to the function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in a similar way as
scip-pythondo.Examples of generated snapshots: sourcegraph/scip-go#172
For sourcegraph/scip-go#92