Allow customizing MoveIt2 docker image tag#223
Conversation
ivanperez-keera
changed the title
ivanperez-keera
force-pushed
the
dev-moveit2-tag
branch
2 times, most recently
from
e63a682 to
d92effa
Compare
Bckempa
left a comment
Bckempa
left a comment
There was a problem hiding this comment.
I think there is a valid argument that the build.sh scripts represent project defaults and if you want to override them you should know enough about Docker to run the build command yourself, but I can see the value in this for advanced CI workflows.
ivanperez-keera
force-pushed
the
dev-moveit2-tag
branch
from
d92effa to
f2e96e8
Compare
|
@Bckempa I've requested the re-review to meet the requirements to merge without bypassing. I applied your suggestion and responded to the other comment. |
|
@Bckempa the build is in a strange state, with several CI jobs crashing atm. Do we want to bypass those or wait until those are fixed (if the fix is simple/quick)? |
For the sake of the record, we discussed that since this wasn't blocking anything we'd prioritize getting CI back to green first. |
ivanperez-keera
force-pushed
the
dev-moveit2-tag
branch
from
f2e96e8 to
64b5b6d
Compare
Currently, the build script for the moveit2 image picks latest as the tag, which prevents us from easily customizing the tag during the build. This commit adjusts the build script for the moveit2 image to pick a tag passed in a variable as MOVEIT2_TAG. If the variable is not set, the latest is used instead, defaulting to the current behavior.
A prior commit adjusted the build script for the moveit2 docker image to allow setting the image tag using a variable MOVEIT2_TAG. This commit adjusts the README to document the new functionality.
ivanperez-keera
force-pushed
the
dev-moveit2-tag
branch
from
64b5b6d to
977bf65
Compare
github-project-automation
bot
moved this from In Review
to Done
in Space ROS Project Development
2 participants
Currently, the build script for the MoveIt2 image picks
latestas the tag, which prevents us from easily customizing the tag during the build.This PR adjusts the build script for the MoveIt2 image to pick a tag passed in a variable as
MOVEIT2_TAG. If the variable is not set,latestis used instead, defaulting to the current behavior.The new feature is documented in the associated README.