Skip to content

Conversation

@Alwayswannahunt
Copy link
Contributor

@Alwayswannahunt Alwayswannahunt commented Nov 3, 2025

About the PR

Adds new component SmartEquipPickupStorageComponent
Adds better smart equip handling for weapons

Check mark for test:

  • PR tested

Why / Balance

It's strange to take out gun's ammo instead of a gun, so now guns knows what you want and jump in your hand!

Technical details

Adds SmartEquipPickupStorageComponent
Adds Check for SmartEquipPickupStorageComponent on slot item to try pick up item instead of piciking from its storage
Adds SmartEquipPickupStorageComponent to weapons prototypes

Media

2025-11-27.223339.mp4

Requirements

Breaking changes

🆑 AlwyAnri

  • tweak: Changed smart equip behavior! Now it takes out weapons instead of items in weapon storage

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. Changes: UI Changes: Might require knowledge of UI design or code. labels Nov 3, 2025
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 3, 2025
@slarticodefast
Copy link
Member

I don't think it makes sense to have a cvar for this. Just make it the normal behaviour.

@Alwayswannahunt
Copy link
Contributor Author

I don't think it makes sense to have a cvar for this. Just make it the normal behaviour.

About pocket slots. Afaik you can put chem or plant bag in it, they should also have same behavior as suit storage or like normal slots?

@arenaconspiracy
Copy link

I've been contemplating this on and off for a while, and made some conclusions.
My first thought was that this should extend to pocket smartequip too, as pulling the pistol magazine instead of your Mk58 is less than ideal. I then recalled having gripes with this when holding weapons in my belt/back slot, it has the same issue of pulling the magazine instead of the weapon. Leaving the issue on those 2 slots would be Not Great. Initially I thought about making it explicitly only affect non-gridinv storage smart equip, but that runs into a problem with the backpack water tank & portable recharger.

I think a much cleaner solution would be to use a simplistic NoRecursiveSmartEquip marker component to be added to entities with item slots, and modify the smart equip system to grab the marked entity instead of it's container contents if it has the component. This way firearms with magazines can get the marker component and be explicitly defined to always be grabbed instead of their magazine/chamber, while other entities with item slots can still have the desired function.

@PJBot PJBot removed the Changes: UI Changes: Might require knowledge of UI design or code. label Nov 27, 2025
@Alwayswannahunt Alwayswannahunt marked this pull request as ready for review November 27, 2025 12:08
@arenaconspiracy
Copy link

❤️

@Alwayswannahunt Alwayswannahunt changed the title Better suit storage smart equip Better weapon smart equip Nov 28, 2025
@murphyneko murphyneko removed the S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. label Dec 9, 2025
@arenaconspiracy
Copy link

You might want to request a review.

@arenaconspiracy
Copy link

The component should probably also be added to items like flashlights and PDAs, among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants