Skip to content

Bugfix for WCS handing non-coordinate inputs/outputs correctly#706

Merged
WilliamJamieson merged 1 commit intospacetelescope:mainfrom
WilliamJamieson:bugfix/non-coordinate
Feb 12, 2026
Merged

Bugfix for WCS handing non-coordinate inputs/outputs correctly#706
WilliamJamieson merged 1 commit intospacetelescope:mainfrom
WilliamJamieson:bugfix/non-coordinate

Conversation

@WilliamJamieson
Copy link
Collaborator

This PR addresses the bug uncovered in spacetelescope/jwst#10245 (comment) where non-coordinate inputs can induce a failure due to zip strictness.

Tasks

  • Update or add relevant gwcs tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR need a changelog entry? (If not, label with no-changelog-entry-needed.)
    • Write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types).
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.breaking.rst: any change or deprecation of the public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner February 12, 2026 17:54
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.47%. Comparing base (adcc56c) to head (8440310).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files          41       41           
  Lines        4288     4289    +1     
=======================================
+ Hits         3665     3666    +1     
  Misses        623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson WilliamJamieson merged commit af2ff57 into spacetelescope:main Feb 12, 2026
23 of 25 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/non-coordinate branch February 12, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants