Update tests for GWCS

[WilliamJamieson]

Resolves JP-nnnn

spacetelescope/gwcs#692 is making it so that a GWCS requires the forward transform and both the input and output frames to be defined properly.

spacetelescope/gwcs#693 is updating GWCS so that strings cannot be used in place of a properly defined coordinate frame.

This PR updates the JWST tests so that this is avoided, before GWCS makes its next release.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (bbf1e5f) to head (a161948).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10245      +/-   ##
==========================================
- Coverage   85.98%   85.33%   -0.65%     
==========================================
  Files         368      370       +2     
  Lines       38457    39132     +675     
==========================================
+ Hits        33066    33393     +327     
- Misses       5391     5739     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pllim]

oldestdeps failed and should be looked into. Thanks!

[melanieclarke]

I think some of the details on the new frames are not quite right. I'll need to do some research to make sure I know which frames should be spatial and spectral and what the units are. I'm a little sad to lose the capability to not care about the details in cases where it really doesn't matter what type of frame it is, but I'm sure there are good reasons for making the change.

[WilliamJamieson]

oldestdeps failed and should be looked into. Thanks!

Dang it, I used too new a version of GWCS to make updates to the data files.

[pllim]

Also please rebase and then run https://github.com/spacetelescope/RegressionTests/actions/workflows/jwst_devdeps.yml on this branch. Thanks!

[WilliamJamieson]

I think some of the details on the new frames are not quite right. I'll need to do some research to make sure I know which frames should be spatial and spectral and what the units are. I'm a little sad to lose the capability to not care about the details in cases where it really doesn't matter what type of frame it is, but I'm sure there are good reasons for making the change.

The best option is to use the CoordinateFrame object and supply minimal information. I can do that here I just tried to guess at what was the correct thing.

[melanieclarke]

Suggestions for more realistic frames below.

But thank you for the suggestion to use CoordinateFrame as well - I'll keep that in my pocket for the future.