JP-3164: Removed or Fixed CI Tests Marked as xfail or skip#10255
JP-3164: Removed or Fixed CI Tests Marked as xfail or skip#10255kmacdonald-stsci wants to merge 2 commits intospacetelescope:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10255 +/- ##
==========================================
- Coverage 85.98% 85.33% -0.65%
==========================================
Files 368 370 +2
Lines 38457 39132 +675
==========================================
+ Hits 33066 33393 +327
- Misses 5391 5739 +348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
melanieclarke
left a comment
There was a problem hiding this comment.
This looks like a good change to me.
I think we can also just remove the xfailed test in jwst/regtest/test_infrastructure.py, since it's unlikely we'll ever add table meta comparison.
Looking at a recent scheduled regtest run, I also see a couple skips that should be investigated:
SKIPPED [1] jwst/datamodels/tests/test_api.py:64: got empty parameter set for (module)
SKIPPED [2] ../../../../home/runner/micromamba/envs/test-jwst/lib/python3.11/site-packages/_pytest/doctest.py:458: all tests skipped by +SKIP option
5cc4161 to
e34e0bc
Compare
I removed this test. |
Resolves JP-3164
This PR addresses
pytestsmarkedxfailorskip. Most tests are marked as such for exception handling, where a precondition for the test to run successfully could not be complete, like connecting to CRDS. Marked tests not fixed or removed need further discussion or are awaiting future development.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files