Skip to content

JP-3164: Removed or Fixed CI Tests Marked as xfail or skip#10255

Open
kmacdonald-stsci wants to merge 2 commits intospacetelescope:mainfrom
kmacdonald-stsci:jp_3164_ci_tests_02
Open

JP-3164: Removed or Fixed CI Tests Marked as xfail or skip#10255
kmacdonald-stsci wants to merge 2 commits intospacetelescope:mainfrom
kmacdonald-stsci:jp_3164_ci_tests_02

Conversation

@kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented Feb 12, 2026

Resolves JP-3164

This PR addresses pytests marked xfail or skip. Most tests are marked as such for exception handling, where a precondition for the test to run successfully could not be complete, like connecting to CRDS. Marked tests not fixed or removed need further discussion or are awaiting future development.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@kmacdonald-stsci kmacdonald-stsci requested a review from a team February 12, 2026 15:09
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (bbf1e5f) to head (e34e0bc).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10255      +/-   ##
==========================================
- Coverage   85.98%   85.33%   -0.65%     
==========================================
  Files         368      370       +2     
  Lines       38457    39132     +675     
==========================================
+ Hits        33066    33393     +327     
- Misses       5391     5739     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me.

I think we can also just remove the xfailed test in jwst/regtest/test_infrastructure.py, since it's unlikely we'll ever add table meta comparison.

Looking at a recent scheduled regtest run, I also see a couple skips that should be investigated:
SKIPPED [1] jwst/datamodels/tests/test_api.py:64: got empty parameter set for (module)
SKIPPED [2] ../../../../home/runner/micromamba/envs/test-jwst/lib/python3.11/site-packages/_pytest/doctest.py:458: all tests skipped by +SKIP option

@kmacdonald-stsci
Copy link
Contributor Author

This looks like a good change to me.

I think we can also just remove the xfailed test in jwst/regtest/test_infrastructure.py, since it's unlikely we'll ever add table meta comparison.

Looking at a recent scheduled regtest run, I also see a couple skips that should be investigated: SKIPPED [1] jwst/datamodels/tests/test_api.py:64: got empty parameter set for (module) SKIPPED [2] ../../../../home/runner/micromamba/envs/test-jwst/lib/python3.11/site-packages/_pytest/doctest.py:458: all tests skipped by +SKIP option

I removed this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants