-
Notifications
You must be signed in to change notification settings - Fork 521
openblas: patch for +dynamic_dispatch target=aarch64 #2903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f5b938 to
931b8f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a patch to the OpenBLAS package to fix compilation issues for version 0.3.30 when built with dynamic dispatch enabled on aarch64 (ARM64) architectures.
- Adds an upstream patch from OpenMathLib/OpenBLAS that fixes HAVE_SME setting for DYNAMIC_ARCH builds using CMake
- Applies specifically to OpenBLAS version 0.3.30 with the dynamic_dispatch variant enabled on aarch64 targets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks like there is a conflict to be resolved. |
tldahlgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathomp4 Any objections to this PR being merged?
Nope. Huh. I thought I'd approved it... |
This PR adds to
openblasa patch which fixes compilation for@0.3.30 +dynamic_dispatch target=aarch64.Test builds (on arm64):