fix: Use Actions.CLOSE_CURRENCY for increase liquidity

[deluca-mike]

Summary by CodeRabbit

• Refactor
  • Updated mint operation settlement process to handle individual currencies separately, improving how currency settlement is structured and processed during transactions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• UniswapV4Lib.sol: The smart contract replaces the "SETTLE_PAIR" action with "CLOSE_CURRENCY," adding separate parameters for each currency.

---

🔗 Commit Hash: 9a1ab5f

[coderabbitai]

Walkthrough

The change modifies mint calldata generation in UniswapV4Lib.sol by replacing a single SETTLE_PAIR action with two CLOSE_CURRENCY actions and restructuring the settlement parameters. The params array size increases from 2 to 3, with currency encodings now passed as separate elements.

Changes

Cohort / File(s)	Summary
Uniswap V4 Mint Calldata src/libraries/UniswapV4Lib.sol	Replaced single SETTLE_PAIR action with two consecutive CLOSE_CURRENCY actions; params array expanded from size 2 to 3; settlement parameters split into two distinct encoded currency params instead of single pair encoding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: Inconsistent Uniswap v4 PositionManager action usage in increasePosition #204: This PR directly reverses the settlement action pattern change—switching back from SETTLE_PAIR to two separate CLOSE_CURRENCY actions with adjusted params array size in the same UniswapV4Lib.sol calldata generation logic.

Suggested reviewers

• lucas-manuel

Poem

🐰 The settlement shifts with a hop and a bound,
One action becomes two—now currency-bound!
From SETTLE_PAIR's grace to CLOSE actions bright,
Parameters grow to set everything right! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: Use Actions.CLOSE_CURRENCY for increase liquidity' is fully related to the main change, which replaces SETTLE_PAIR with CLOSE_CURRENCY actions in mint calldata generation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/close-curency-for-increase-liquidity

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage after merging fix/close-curency-for-increase-liquidity into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.36%	99.24%	587–588
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WeEthModule.sol	92.86%	75%	100%	100%	26, 38
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WeETHLib.sol	100%	100%	100%	100%

[octane-security-app]

Overview

Vulnerabilities found:	3

---

🔗 Commit Hash: 9a1ab5f
🛡️ Octane Dashboard: All vulnerabilities