Skip to content

fix centroid correction and allow arbitrary angles #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix centroid correction and allow arbitrary angles #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions KiCad-Conversion/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import os
import argparse

import math

# Used for pulling data from g spreadsheet
import csv
Expand Down Expand Up @@ -260,6 +261,9 @@ def load_component_info(component_position_file, offset, mirror_x, board_width):
# Find the associated feeder
feeder = get_feeder(components[componentCount].feeder_ID)

# Save the original rotation as was specified on the PCB. Will need that later for centroid corrections
originalRotation = components[componentCount].rotation

# Correct tape orientation (mounted 90 degrees from the board)
components[componentCount].rotation = components[componentCount].rotation - 90

Expand All @@ -276,24 +280,19 @@ def load_component_info(component_position_file, offset, mirror_x, board_width):
if(mirror_x):
components[componentCount].rotation = -components[componentCount].rotation

# There are some components that have a centroid point in the wrong place (Qwiic Connector)
# If this component has a correction, use it
if(components[componentCount].rotation == -180.0):
components[componentCount].x = components[componentCount].x + feeder.centroid_correction_y
components[componentCount].y = components[componentCount].y + feeder.centroid_correction_x
elif(components[componentCount].rotation == 180.0): # Duplicate of first
components[componentCount].x = components[componentCount].x + feeder.centroid_correction_y
components[componentCount].y = components[componentCount].y + feeder.centroid_correction_x
elif(components[componentCount].rotation == -90.0):
components[componentCount].y = components[componentCount].y + feeder.centroid_correction_y
components[componentCount].x = components[componentCount].x + feeder.centroid_correction_x
elif(components[componentCount].rotation == 0.0):
components[componentCount].x = components[componentCount].x - feeder.centroid_correction_y
components[componentCount].y = components[componentCount].y - feeder.centroid_correction_x
elif(components[componentCount].rotation == 90.0):
components[componentCount].y = components[componentCount].y - feeder.centroid_correction_y
components[componentCount].x = components[componentCount].x - feeder.centroid_correction_x

# Apply centroid correction and allow for arbitrary angles by rotating the correction
# We need to rotate the correction by the original rotation as was specified on the PCB
# because centroid correction will be relative to the footprint, before any feeder/tape corrections
x = feeder.centroid_correction_x
y = feeder.centroid_correction_y
# TODO do we need to handle mirror_x, and negate the originalRotation?
angle = math.radians(originalRotation)
x_new = x * math.cos(angle) - y * math.sin(angle)
y_new = x * math.sin(angle) + y * math.cos(angle)
components[componentCount].x = components[componentCount].x + x_new
components[componentCount].y = components[componentCount].y + y_new


# Assign pick head, speed and other feeder parameters
components[componentCount].head = feeder.head
components[componentCount].place_component = feeder.place_component
Expand Down