PCP-4205: 🐛 fix: separate control plane logging and vpc config updates

[pavansokkenagaraj]

ref:
kubernetes-sigs#3553 (comment)
kubernetes-sigs#4918 (comment)
kubernetes-sigs#5441
kubernetes-sigs#5442

---

What type of PR is this?
/kind bug

---

What this PR does / why we need it:
What this PR does / why we need it:

EKS does not allow for both a VPC config update and a logging update in the same API call. If both of these changes are applied to the spec at once, then the AWSManagedControlPlane will fail to reconcile.

Addresses the restriction in the EKS API by separating logging and vpc config updates into two separate steps.

---

Try updating EKS cluster's logging config and vpc config at a time.
EKS doesn't allow multiple types of updates at once and this would fail
aws eks update-cluster-config --name --resources-vpc-config '{"endpointPrivateAccess":true}' --logging '{"clusterLogging":[{"types":["authenticator"],"enabled":true}]}'

An error occurred (InvalidParameterException) when calling the UpdateClusterConfig operation: Only one type of update can be allowed.

---

Observed when CAPA reconciles private endpoints when EKS deployed with endpoint access: private

271] [capa-controller-manager-694c8f6879-wxg8q] 1 controller.go:326] "msg"="Reconciler error" "error"="failed to reconcile control plane for AWSManagedControlPlane cluster-67bdf4503897e994b608c9f3/dustin-eks-privatetest-cp: failed reconciling cluster config: failed to update EKS cluster: InvalidParameterException: Cluster is already at the desired configuration with endpointPrivateAccess: true , endpointPublicAccess: false, and Public Endpoint Restrictions: [52.35.163.177/32, 44.233.247.65/32, 18.144.153.171/32, 52.6.49.233/32, 54.80.29.137/32, 13.52.68.206/32, 54.158.209.13/32, 44.232.106.120/32]\n{\n RespMetadata: {\n StatusCode: 400,\n RequestID: \"10163f97-d89b-44c1-bee1-75a3c476b980\"\n },\n ClusterName: \"dustin-eks-privatetest\",\n Message_: \"Cluster is already at the desired configuration with endpointPrivateAccess: true , endpointPublicAccess: false, and Public Endpoint Restrictions: [52.35.163.177/32, 44.233.247.65/32, 18.144.153.171/32, 52.6.49.233/32, 54.80.29.137/32, 13.52.68.206/32, 54.158.209.13/32, 44.232.106.120/32]\"\n}" "AWSManagedControlPlane"={"name":"dustin-eks-privatetest-cp","namespace":"cluster-67bdf4503897e994b608c9f3"} "controller"="awsmanagedcontrolplane" "controllerGroup"="controlplane.cluster.x-k8s.io" "controllerKind"="AWSManagedControlPlane" "name"="dustin-eks-privatetest-cp" "namespace"="cluster-67bdf4503897e994b608c9f3" "reconcileID"="81216a1c-47f8-4059-b3b4-4f9664c3806f"

---

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

[AmitSahastra]

LGTM!

[AmitSahastra]

Please help add description to PR

[spectro-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmitSahastra, pavansokkenagaraj
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment