Skip to content

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Oct 5, 2023

Fix #11675.

@mgeier or @humitos, could you confirm that this patch works as intended?

cc @AA-Turner

@humitos
Copy link
Contributor

humitos commented Oct 5, 2023

I'm on vacation. I can take a look at it next week 👍

@picnixz
Copy link
Member Author

picnixz commented Oct 5, 2023

Ah sorry! no worry, it is not a pressing issue. Have a nice holidays!

@mgeier
Copy link
Contributor

mgeier commented Oct 5, 2023

could you confirm that this patch works as intended?

Yes, works like a charm!
See https://readthedocs.org/projects/nbsphinx/builds/22136182/

@humitos
Copy link
Contributor

humitos commented Oct 11, 2023

Thanks @mgeier for testing this! I'm happy it's working as expected 🚀 Thanks @picnixz too for fixing the issue 😉

@AA-Turner AA-Turner merged commit a8d5800 into sphinx-doc:master Dec 30, 2023
@picnixz picnixz deleted the fix/11675-ANSI-color-detection branch December 30, 2023 16:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in terminal color auto-detection?

4 participants