Skip to content

Fix detection of ANSI control sequence support #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 30, 2023
Merged

Fix detection of ANSI control sequence support #11708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d36668
Fix detection of ANSI control sequence support
picnixz Oct 5, 2023
f8253b7
update comment
picnixz Oct 5, 2023
8e58247
update comment
picnixz Oct 5, 2023
7845db3
Merge branch 'master' into fix/11675-ANSI-color-detection
picnixz Oct 9, 2023
6c61d30
Merge branch 'master' into fix/11675-ANSI-color-detection
picnixz Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Bugs fixed
package (triggered if using ``fontenc`` with ``T2A`` option and document
language is not a Cyrillic one).
Patch by Jean-François B.
* #11675: Fix rendering of progression bars in environments that do not support
ANSI control sequences.
Patch by Bénédikt Tran.

Testing
-------
Expand Down
5 changes: 3 additions & 2 deletions sphinx/util/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from sphinx.locale import __
from sphinx.util import logging
from sphinx.util.console import bold # type: ignore[attr-defined]
from sphinx.util.console import bold, color_terminal # type: ignore[attr-defined]

if False:
from collections.abc import Iterable, Iterator
Expand Down Expand Up @@ -33,7 +33,8 @@ def status_iterator(
verbosity: int = 0,
stringify_func: Callable[[Any], str] = display_chunk,
) -> Iterator[T]:
single_line = verbosity < 1
# printing on a single line requires ANSI control sequences
single_line = verbosity < 1 and color_terminal()
bold_summary = bold(summary)
if length == 0:
logger.info(bold_summary, nonl=True)
Expand Down