Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Sep 26, 2024

Describe your changes

  • Updates the job api group to batch for correct RBAC

Note: I'm not yet able to fully test via the make build deploy flow as RBAC issues remain. Next up are node permissions, which will require a rewrite of node_controller.go.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@github-actions github-actions bot added the kind/bug Something isn't working label Sep 26, 2024
@voigt voigt merged commit f1d9cd1 into spinframework:main Sep 30, 2024
7 checks passed
@vdice vdice deleted the fix/job-rbac branch October 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants