Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Apr 16, 2025

Describe your changes

Adds test automation to verify rcm's functionality in the context of node scaling.

Hoping this automation (or some variant thereof, per feedback) in combination with manual testing (say on AKS or other cloud vendors) is sufficient to close #222 cc @Mossaka

Further, I'm proposing we'll be able to remove the commented-out node_controller.go file completely -- at least until we either have a need for functionality beyond what the shim_controller does today, or we'd like to invest in a refactor to better isolate concerns.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice force-pushed the ci/add-node-scaling-test branch from b367625 to 80cee14 Compare April 17, 2025 16:09
@vdice vdice merged commit 4868fab into spinframework:main Apr 17, 2025
14 checks passed
@vdice vdice deleted the ci/add-node-scaling-test branch April 17, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for persistent node labels for node stop/restart

2 participants