GitHub action to update Spin CLI reference #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
approved these changes
Apr 3, 2025
Contributor
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
I think it just needs one fixup but then glad to get this merged so you can test.
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Download Spin | ||
| uses: fermyon/actions/spin/setup@v1 |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: fermyon/actions/spin/setup@v1 | |
| uses: fermyon/actions/spin/setup@v1 | |
| with: | |
| version: canary |
Just missing a with: line prior to the customizations. (Don't commit this change, just used it to sketch out.)
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
update-spin-cli-reference
branch
from
92bec45 to
af093a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe I can test this outside of main. Would folks be okay with me merging it as is, and then testing or reverting it? It should be benign because the action is only manual dispatch, and I believe the only thing it can do is create a PR (which I will review and then close). Thanks!