fix(*): main/hub search #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://spin-docs-pr-94-7pswu4zi.fermyon.app |
Contributor
|
@karthik2804 it would be really good to get this working again |
Signed-off-by: Vaughn Dice <[email protected]> Co-authored-by: Karthik Ganeshram <[email protected]>
Contributor
Author
itowlson
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
With the first commit, I've updatedglobusage (referencing the latest 11.0.x docs) so that the mainstatic/data.jsonand Spin Hubstatic/hub-index-data.jsonfiles are now properly (?) being created. However, search functionality still doesn't appear to be working.Hoping for a collabo w/ @karthik2804 on this one.Successful collabo w/ @karthik2804 - indeed,
globusage needed to be updated (Karthik had a simpler update), in addition to usage of scripts in package.json. Hub search now working as intended (verified with the preview at https://spin-docs-pr-94-7pswu4zi.fermyon.app/)