ref(*): remove kube-rbac-proxy #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
vdice
requested review from
bacongobbler,
calebschoepp,
endocrimes,
michelleN and
rajatjindal
as code owners
vdice
commented
Jan 9, 2025
| // https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/filters#WithAuthenticationAndAuthorization | ||
| metricsServerOptions.FilterProvider = filters.WithAuthenticationAndAuthorization | ||
|
|
||
| // TODO(user): If CertDir, CertName, and KeyName are not specified, controller-runtime will automatically |
There was a problem hiding this comment.
This was lifted from the upstream example project code, but I also see instructions in kubernetes-sigs/kubebuilder#3907 to have cert-manager cover certs for the metrics-server, presumably similar to the webhook-server. Shall we do this?
There was a problem hiding this comment.
Ok, created a follow-up: #364
endocrimes
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #354, removes the deprecated
kube-rbac-proxycomponent.I followed the instructions in kubernetes-sigs/kubebuilder#3907 to manually update this project. Added an e2e test for the metrics server functionality.
Closes #354