Respect the exclude files option in the spin toml manifest #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aminu 'Seun Joshua <[email protected]> - fmt Signed-off-by: Aminu 'Seun Joshua <[email protected]> - cleaner code Signed-off-by: Aminu 'Seun Joshua <[email protected]>
seun-ja
force-pushed
the
respect-the-exclude-files-option-in-the-spin-toml-manifest
branch
from
7494c3f to
bc2246c
Compare
rylev
reviewed
Jul 31, 2025
|
|
||
| // Host path is the absolute path to the file | ||
| let host_path = self.manifest.absolute_from(host_path); | ||
| // If the file among list of files to be excluded, skip it |
There was a problem hiding this comment.
host_path is an absolute path but I think the paths in exclude_files are relative to the manifest. Have you run this code to see if it works? I don't think we have tests for the runtime, but it would be really nice if we did.
There was a problem hiding this comment.
I couldn't run it because I keep running into the type mismatch error.
Looking at the sample provided for what an exclude_files can be like it looks to be in form of relative path. I would used relative path instead.
Signed-off-by: Aminu 'Seun Joshua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #79
checks if
host_pathis the path of the app manifest's componentexclude_files