Skip to content

Respect the exclude files option in the spin toml manifest #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −1
Open

Respect the exclude files option in the spin toml manifest #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2246c
- respects component exclude files
seun-ja Jul 29, 2025
faabe7a
check against relative file name
seun-ja Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ impl Runtime {

/// Make all mounted files visible to the WASI virtual filesystem
fn add_files(&mut self, runner: dynamic::DynamicRunner) -> anyhow::Result<()> {
//TODO(rylev): handle component.exclude_files
/// Make a file visible to the WASI virtual filesystem
fn add_file<T>(
store: &mut wasmtime::Store<T>,
Expand All @@ -114,8 +113,19 @@ impl Runtime {
format!("failed to read glob entry for pattern '{p}'")
})?;

// If the file among list of files to be excluded, skip it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host_path is an absolute path but I think the paths in exclude_files are relative to the manifest. Have you run this code to see if it works? I don't think we have tests for the runtime, but it would be really nice if we did.

Copy link
Author

@seun-ja seun-ja Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't run it because I keep running into the type mismatch error.

Looking at the sample provided for what an exclude_files can be like it looks to be in form of relative path. I would used relative path instead.

if self
.manifest
.component()
.exclude_files
.contains(&host_path.display().to_string())
{
continue;
}

// Host path is the absolute path to the file
let host_path = self.manifest.absolute_from(host_path);

// Only add files
if !host_path.is_file() {
continue;
Expand All @@ -139,6 +149,12 @@ impl Runtime {
.strip_prefix('/')
.unwrap_or(destination.as_str())
);

// If the file among list of files to be excluded, skip it
if self.manifest.component().exclude_files.contains(source) {
continue;
}

let host_path = self.manifest.absolute_from(source);

// If the host path is a directory, add all files in the directory
Expand Down