Skip to content

Conversation

@vdice
Copy link
Contributor

@vdice vdice commented Nov 8, 2024

Tested via the example apps.

*This was done to address the following compilation conflict:

$ cargo build --release
    Updating crates.io index
    Updating git repository `https://github.com/fermyon/spin`
error: failed to select a version for `tokio`.
    ... required by package `trigger-command v0.1.0 (/Users/vdice/code/github.com/fermyon/spin-trigger-command)`
versions that meet the requirements `^1.40` are: 1.40.0, 1.41.1, 1.41.0

all possible versions conflict with previously selected packages.

  previously selected package `tokio v1.38.0`
    ... which satisfies dependency `tokio = "~1.38.0"` of package `opentelemetry-otlp v0.25.0`
    ... which satisfies dependency `opentelemetry-otlp = "^0.25"` of package `spin-telemetry v3.0.0 (https://github.com/fermyon/spin?tag=v3.0.0#737778e9)`
    ... which satisfies git dependency `spin-telemetry` of package `trigger-command v0.1.0 (/Users/vdice/code/github.com/fermyon/spin-trigger-command)`

failed to select a version for `tokio` which could resolve this conflict

Also update usage in src/lib.rs

Signed-off-by: Vaughn Dice <[email protected]>
Co-authored-by: Brian Hardock <[email protected]>
@vdice vdice force-pushed the chore/bump-spin-crates-v3.0.0 branch from a50c3fd to a688e20 Compare November 8, 2024 18:08
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0!

@vdice vdice merged commit eb79c37 into spinframework:main Nov 8, 2024
1 check passed
@vdice vdice deleted the chore/bump-spin-crates-v3.0.0 branch November 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants