selects only id when checking existence of data #3233
Merged
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
lann
reviewed
Aug 18, 2025
lann
reviewed
Aug 18, 2025
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
Contributor
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
@seun-ja thank you for adding these changes! My suggestion's are similar to Lann's. Do you mind also confirming that your changes work with manual tests?
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
kate-goldenring
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2921
PR sieves out redundant data, only checks for
id. Does the same forget_keys_query, only querying forc.idandc.store_id(needed for deserialising toKeystruct), thereby excluding possible heavy data fromvalue