Skip to content

selects only id when checking existence of data #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
+19 −2
Merged

selects only id when checking existence of data #3233

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40c4390
selects only id when checking existence of data
seun-ja Aug 15, 2025
c9c16ea
cleaner code
seun-ja Aug 18, 2025
21bd073
store_id added to query
seun-ja Aug 18, 2025
f9079a4
handle optional store_id
seun-ja Aug 19, 2025
3d8f574
revert
seun-ja Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions crates/key-value-azure/src/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,18 @@ impl Store for AzureCosmosStore {
}

async fn exists(&self, key: &str) -> Result<bool, Error> {
Ok(self.get_entity::<Key>(key).await?.is_some())
let mut stream = self
.client
.query_documents(Query::new(self.get_id_query(key)))
.query_cross_partition(true)
.max_item_count(1)
.into_stream::<Key>();

match stream.next().await {
Some(Ok(res)) => Ok(!res.results.is_empty()),
Some(Err(e)) => Err(log_error(e)),
None => Ok(false),
}
}

async fn get_keys(&self) -> Result<Vec<String>, Error> {
Expand Down Expand Up @@ -446,8 +457,14 @@ impl AzureCosmosStore {
query
}

fn get_id_query(&self, key: &str) -> String {
let mut query = format!("SELECT c.id, c.store_id FROM c WHERE c.id='{key}'");
self.append_store_id(&mut query, true);
query
}

fn get_keys_query(&self) -> String {
let mut query = "SELECT * FROM c".to_owned();
let mut query = "SELECT c.id, c.store_id FROM c".to_owned();
self.append_store_id(&mut query, false);
query
}
Expand Down
Loading