Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

fix(pipelineStage): Rendering with a warning with the pipelineParameters are defined as a SpeL expression#10168

Merged
mergify[bot] merged 1 commit intospinnaker:masterfrom
armory-io:fixPipelineStartRenderSpel
Mar 17, 2025
Merged

fix(pipelineStage): Rendering with a warning with the pipelineParameters are defined as a SpeL expression#10168
mergify[bot] merged 1 commit intospinnaker:masterfrom
armory-io:fixPipelineStartRenderSpel

Conversation

@christosarvanitis
Copy link
Member

@christosarvanitis christosarvanitis commented Mar 17, 2025

Although not used by many a user can define the pipelineParameters in the pipeline json as a single SpeL expression and this will be evaluated by Orca during the execution.
Deck however doesnt render this correctly.

Stage json:

{
  "application": "testpipline",
  "failPipeline": true,
  "name": "Pipeline",
  "pipeline": "497ba489-beef-4e60-badb-32f2798c8fac",
  "pipelineParameters": "${{parameters.p1: parameters.p2}}",
  "type": "pipeline",
  "waitForCompletion": true
}

Before the fix:

Screenshot 2025-03-17 at 15 47 17

After the fix:

Screenshot 2025-03-17 at 15 43 49

@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label Mar 17, 2025
@mergify mergify bot added the auto merged Merged automatically by a bot label Mar 17, 2025
@mergify mergify bot merged commit 294e0ed into spinnaker:master Mar 17, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.38

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants