Skip to content

Conversation

@patrykw-splunk
Copy link
Collaborator

Description

This PR adds support for creation of PVs per CR to the helm deployments. This is a result of #1509 change, and should be merged after it.
As an addition I've also removed empty lines from values.yaml to adjust it to the universal standards of Helm-charts

Key Changes

  • new template for creation of Persistent Volumes per CR - pvs.yaml
  • move of CRs specific configs under customResources block in `values.yaml
  • adjustments of templates regarding previous point
  • deletion of empty lines in values.yaml

Testing and Verification

local tests
helm template release-splunk . -n splunk-operator --set customResources.standalone.enablePersistentVolume=true --set splunk-operator.enabled=false --set installCRDs=false & addition of adjusted values.yaml`

Related Issues

PR Checklist

  • Code changes adhere to the project's coding standards.
  • [N/A] Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15190106022

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.613%

Totals Coverage Status
Change from base Build 14926894990: 0.0%
Covered Lines: 10546
Relevant Lines: 12176

💛 - Coveralls

@patrykw-splunk patrykw-splunk changed the title Add pvs.yaml template and remove empty lines from values.yaml [draft] Add pvs.yaml template and remove empty lines from values.yaml May 29, 2025
@patrykw-splunk patrykw-splunk deleted the helm-add-pv-creation-template branch November 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants