Skip to content

Conversation

@kasiakoziol
Copy link
Collaborator

@kasiakoziol kasiakoziol commented Oct 17, 2025

Description

This PR simplifies the inputs for I&I separation. Instead of passing a lot of inputs to the IndexerCluster and IngestorCluster that are the same and are shared among them in a single cluster setup, the inputs are provided once to a BusConfiguration CR which can be then referenced by IndexerCluster and IngestorCluster . What is more, the number of inputs is decreased only to the ones that matter and are clear to the users (bus specific values). The rest of them is assigned fixed values.

Key Changes

  • New CR: BusConfiguration
  • Fixed values for pipeline configuration and some bus config inputs

Testing and Verification

  • Automated tests
  • Manual tests

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-4022

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2025

Pull Request Test Coverage Report for Build 18843723031

Details

  • 246 of 362 (67.96%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 85.59%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/splunk/enterprise/types.go 0 2 0.0%
pkg/splunk/enterprise/util.go 8 12 66.67%
pkg/splunk/enterprise/ingestorcluster.go 68 74 91.89%
internal/controller/indexercluster_controller.go 14 25 56.0%
pkg/splunk/enterprise/busconfiguration.go 71 84 84.52%
internal/controller/ingestorcluster_controller.go 9 25 36.0%
internal/controller/busconfiguration_controller.go 28 52 53.85%
pkg/splunk/enterprise/indexercluster.go 48 88 54.55%
Totals Coverage Status
Change from base Build 18556177366: -0.5%
Covered Lines: 11244
Relevant Lines: 13137

💛 - Coveralls

@kasiakoziol kasiakoziol force-pushed the feature/CSPL-4022-move-inputs-to-cr branch from 4a67e92 to 6345e6c Compare October 17, 2025 10:07
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-4022-move-inputs-to-cr branch from 6345e6c to 7480ed8 Compare October 17, 2025 10:13
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-4022-move-inputs-to-cr branch 5 times, most recently from 3125779 to a8da5f4 Compare October 24, 2025 09:59
@kasiakoziol kasiakoziol force-pushed the feature/CSPL-4022-move-inputs-to-cr branch from b8b7285 to db02bfd Compare October 27, 2025 10:07
@kasiakoziol kasiakoziol marked this pull request as ready for review October 28, 2025 07:57
@kasiakoziol kasiakoziol merged commit 6618a3f into feature/CSPL-3558-integ-tests Oct 28, 2025
36 of 39 checks passed
@kasiakoziol kasiakoziol deleted the feature/CSPL-4022-move-inputs-to-cr branch October 28, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants