Merged
Conversation
mjburghard
force-pushed
the
add-EmptyDisposable
branch
2 times, most recently
from
219fab2 to
0bf84b3
Compare
zvonicek
reviewed
Mar 4, 2024
Collaborator
zvonicek
left a comment
zvonicek
left a comment
There was a problem hiding this comment.
overall looks like a good convenience to add
| } | ||
|
|
||
| public extension Disposable where Self == EmptyDisposable { | ||
| static var empty: EmptyDisposable { EmptyDisposable() } |
Collaborator
There was a problem hiding this comment.
Since the disposable will be most of the times used through this getter, I would suggest to add documentation to it, such as:
Suggested change
| static var empty: EmptyDisposable { EmptyDisposable() } | |
| /// Gets the disposable that does nothing when disposed. | |
| static var empty: EmptyDisposable { EmptyDisposable() } |
| } | ||
|
|
||
| public extension Disposable where Self == EmptyDisposable { | ||
| static var empty: EmptyDisposable { EmptyDisposable() } |
Collaborator
There was a problem hiding this comment.
Since we don't need the concrete type outside, could you return just Disposable? (on iOS 13+ even some Disposable, but I think that the target here is lower)
mjburghard
force-pushed
the
add-EmptyDisposable
branch
from
0bf84b3 to
149d395
Compare
dflems
previously approved these changes
Mar 26, 2026
Updated copyright notice and license header.
dflems
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.