Conversation
|
I added a fix for the self-type issue but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old. |
Nice!
Ah, we can use a cross-dependency for the tests etorreborre/specs2#848 |
|
Cool, I fixed all the compilation issues but now it seems that
|
Ultimately, we would want to use derivation in Scala 3, but I guess it would be nice to support it in a simpler way until then? |
\u unicode encodes don't seem to supported any more in Scala 3 (at least in tripple quoted strings)
|
Fixed the remaining issues, was pretty trivial after all. |
Since it's not supported anymore. While we'll still publish 2.10 artifacts, perhaps it's fine to stop checking binary compatibility.
raboof
changed the title
|
/cc @jrudolph this might now be good to go? |
Backport of spray#342 to the release-1.3.x branch
Backport of #342 to the release-1.3.x branch
|
Is this dead? |
|
With #345 merged and https://repo1.maven.org/maven2/io/spray/spray-json_3/1.3.6/ published this PR isn't so urgent anymore - the project is in 'maintainance mode' (https://github.com/spray/spray-json#maintanance-mode) and perhaps there won't even really be a need for a 1.4.x release |
| val fields = clazz.getDeclaredFields.filterNot { f => | ||
| import Modifier._ | ||
| (f.getModifiers & (TRANSIENT | STATIC | 0x1000 /* SYNTHETIC*/ )) > 0 | ||
| (f.getModifiers & (TRANSIENT | STATIC | 0x1000 /* SYNTHETIC*/ )) > 0 || f.getName.endsWith("$outer") |
There was a problem hiding this comment.
As scala/scala3#14083 was fixed in Scala 3.1.2, if you update the Scala 3 version this OR is no longer needed.
4 participants
Fixes #341