Building with scala 3 (backport)#345
Merged
raboof merged 9 commits intospray:release/1.3.xfrom Dec 9, 2021
Merged
Conversation
raboof
force-pushed
the
scala3-backport
branch
from
d1f383d to
e1d7ec8
Compare
jrudolph
approved these changes
Dec 9, 2021
Member
jrudolph
left a comment
jrudolph
left a comment
There was a problem hiding this comment.
LGTM with a few cosmetic comments
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version=1.2.7 | |||
| sbt.version=1.5.4 | |||
| val fields = clazz.getDeclaredFields.filterNot { f => | ||
| import Modifier._ | ||
| (f.getModifiers & (TRANSIENT | STATIC | 0x1000 /* SYNTHETIC*/)) > 0 | ||
| (f.getModifiers & (TRANSIENT | STATIC | 0x1000 /* SYNTHETIC*/)) > 0 || f.getName.endsWith("$outer") |
Member
There was a problem hiding this comment.
Maybe add a comment why that's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #342 to the release-1.3.x branch