Skip to content

Conversation

@apollyon4
Copy link

I removed @Validated from all predicates because it wasn't working.
Added @NotNull to BeforeRoutePredicateFactory.Config similar to AfterRoutePredicateFactory.

And I added some tests to verify correct behavior before and after removing @Validated and adding @NotNull.

This is a PR for the #3478 issue.

@apollyon4
Copy link
Author

While working on the predicates, I thought that if there’s no intention to configure the PathRoutePredicateFactory, HostRoutePredicateFactory, and MethodRoutePredicateFactory in a meaningful way, there’s no real reason to include them. Therefore, I think a null check for them would be necessary.

@spencergibb spencergibb changed the title Restoring preidicate consistency by remove 'Validated' and adding 'Notnull'. Restoring predicate consistency by removing 'Validated' and adding 'Notnull'. Nov 20, 2024
spencergibb added a commit that referenced this pull request Nov 20, 2024
@spencergibb spencergibb merged commit 237ce38 into spring-cloud:main Nov 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants