Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.List;
import java.util.function.Predicate;

import jakarta.validation.constraints.NotNull;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -65,6 +66,7 @@ public String toString() {

public static class Config {

@NotNull
private ZonedDateTime datetime;

public ZonedDateTime getDatetime() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import jakarta.validation.constraints.NotNull;

import org.springframework.util.Assert;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -75,7 +74,6 @@ public String toString() {
};
}

@Validated
public static class Config {

@NotNull
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import jakarta.validation.constraints.NotEmpty;

import org.springframework.http.HttpCookie;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -79,7 +78,6 @@ public String toString() {
};
}

@Validated
public static class Config {

@NotEmpty
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import jakarta.validation.constraints.NotEmpty;

import org.springframework.util.StringUtils;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -90,7 +89,6 @@ public String toString() {
};
}

@Validated
public static class Config {

@NotEmpty
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import org.springframework.core.style.ToStringCreator;
import org.springframework.util.AntPathMatcher;
import org.springframework.util.PathMatcher;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -115,7 +114,6 @@ public String toString() {
};
}

@Validated
public static class Config {

private List<String> patterns = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import java.util.function.Predicate;

import org.springframework.http.HttpMethod;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

import static java.util.Arrays.stream;
Expand Down Expand Up @@ -67,7 +66,6 @@ public String toString() {
};
}

@Validated
public static class Config {

private HttpMethod[] methods;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

import org.springframework.core.style.ToStringCreator;
import org.springframework.http.server.PathContainer;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;
import org.springframework.web.util.pattern.PathPattern;
import org.springframework.web.util.pattern.PathPattern.PathMatchInfo;
Expand Down Expand Up @@ -134,7 +133,6 @@ public String toString() {
};
}

@Validated
public static class Config {

private List<String> patterns = new ArrayList<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import jakarta.validation.constraints.NotEmpty;

import org.springframework.util.StringUtils;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

/**
Expand Down Expand Up @@ -84,7 +83,6 @@ public String toString() {
};
}

@Validated
public static class Config {

@NotEmpty
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.apache.commons.logging.LogFactory;

import org.springframework.cloud.gateway.support.ipresolver.RemoteAddressResolver;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.server.ServerWebExchange;

import static org.springframework.cloud.gateway.support.ShortcutConfigurable.ShortcutType.GATHER_LIST;
Expand Down Expand Up @@ -117,7 +116,6 @@ private void addSource(List<IpSubnetFilterRule> sources, String source) {
sources.add(new IpSubnetFilterRule(ipAddress, cidrPrefix, IpFilterRuleType.ACCEPT));
}

@Validated
public static class Config {

@NotEmpty
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@

import java.time.ZonedDateTime;
import java.util.HashMap;
import java.util.Set;
import java.util.function.Predicate;

import jakarta.validation.ConstraintViolation;
import jakarta.validation.Validation;
import jakarta.validation.Validator;
import jakarta.validation.ValidatorFactory;
import org.junit.jupiter.api.Test;

import org.springframework.cloud.gateway.handler.predicate.AfterRoutePredicateFactory.Config;
Expand Down Expand Up @@ -99,4 +104,29 @@ public void toStringFormat() {
assertThat(predicate.toString()).contains("After: " + config.getDatetime());
}

@Test
public void testConfig() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
config.setDatetime(ZonedDateTime.now());

assertThat(validator.validate(config).isEmpty()).isTrue();
}
}

@Test
public void testConfigNullField() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
Set<ConstraintViolation<Config>> validate = validator.validate(config);

assertThat(validate.isEmpty()).isFalse();
assertThat(validate.size()).isEqualTo(1);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,17 @@

import java.time.ZonedDateTime;
import java.util.HashMap;
import java.util.Set;
import java.util.function.Predicate;

import jakarta.validation.ConstraintViolation;
import jakarta.validation.Validation;
import jakarta.validation.Validator;
import jakarta.validation.ValidatorFactory;
import org.junit.jupiter.api.Test;

import org.springframework.cloud.gateway.handler.predicate.BeforeRoutePredicateFactory.Config;

import static org.assertj.core.api.Assertions.assertThat;
import static org.springframework.cloud.gateway.handler.predicate.BeforeRoutePredicateFactory.DATETIME_KEY;
import static org.springframework.cloud.gateway.handler.predicate.BetweenRoutePredicateFactoryTests.bindConfig;
Expand Down Expand Up @@ -85,17 +92,42 @@ private boolean runPredicate(String dateString) {

BeforeRoutePredicateFactory factory = new BeforeRoutePredicateFactory();

BeforeRoutePredicateFactory.Config config = bindConfig(map, factory);
Config config = bindConfig(map, factory);

return factory.apply(config).test(getExchange());
}

@Test
public void toStringFormat() {
BeforeRoutePredicateFactory.Config config = new BeforeRoutePredicateFactory.Config();
Config config = new Config();
config.setDatetime(ZonedDateTime.now());
Predicate predicate = new BeforeRoutePredicateFactory().apply(config);
assertThat(predicate.toString()).contains("Before: " + config.getDatetime());
}

@Test
public void testConfig() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
config.setDatetime(ZonedDateTime.now());

assertThat(validator.validate(config).isEmpty()).isTrue();
}
}

@Test
public void testConfigNullField() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
Set<ConstraintViolation<Config>> validate = validator.validate(config);

assertThat(validate.isEmpty()).isFalse();
assertThat(validate.size()).isEqualTo(1);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,17 @@
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.util.HashMap;
import java.util.Set;
import java.util.function.Predicate;

import jakarta.validation.ConstraintViolation;
import jakarta.validation.Validation;
import jakarta.validation.Validator;
import jakarta.validation.ValidatorFactory;
import org.junit.jupiter.api.Test;

import org.springframework.boot.convert.ApplicationConversionService;
import org.springframework.cloud.gateway.handler.predicate.BetweenRoutePredicateFactory.Config;
import org.springframework.cloud.gateway.support.ConfigurationService;
import org.springframework.cloud.gateway.support.StringToZonedDateTimeConverter;
import org.springframework.mock.http.server.reactive.MockServerHttpRequest;
Expand Down Expand Up @@ -152,19 +158,45 @@ boolean runPredicate(String dateString1, String dateString2) {

BetweenRoutePredicateFactory factory = new BetweenRoutePredicateFactory();

BetweenRoutePredicateFactory.Config config = bindConfig(map, factory);
Config config = bindConfig(map, factory);

return factory.apply(config).test(getExchange());
}

@Test
public void toStringFormat() {
BetweenRoutePredicateFactory.Config config = new BetweenRoutePredicateFactory.Config();
Config config = new Config();
config.setDatetime1(ZonedDateTime.now());
config.setDatetime2(ZonedDateTime.now().plusHours(1));
Predicate predicate = new BetweenRoutePredicateFactory().apply(config);
assertThat(predicate.toString())
.contains("Between: " + config.getDatetime1() + " and " + config.getDatetime2());
}

@Test
public void testConfig() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
config.setDatetime1(ZonedDateTime.now());
config.setDatetime2(ZonedDateTime.now());

assertThat(validator.validate(config).isEmpty()).isTrue();
}
}

@Test
public void testConfigNullField() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
Set<ConstraintViolation<Config>> validate = validator.validate(config);

assertThat(validate.isEmpty()).isFalse();
assertThat(validate.size()).isEqualTo(2);
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@

package org.springframework.cloud.gateway.handler.predicate;

import java.util.Set;
import java.util.function.Predicate;

import jakarta.validation.ConstraintViolation;
import jakarta.validation.Validation;
import jakarta.validation.Validator;
import jakarta.validation.ValidatorFactory;
import org.junit.jupiter.api.Test;

import org.springframework.cloud.gateway.handler.predicate.CookieRoutePredicateFactory.Config;
Expand Down Expand Up @@ -64,4 +69,30 @@ public void toStringFormat() {
assertThat(predicate.toString()).contains("Cookie: name=mycookie regexp=myregexp");
}

@Test
public void testConfig() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
config.setName("mycookie");
config.setRegexp("myregexp");

assertThat(validator.validate(config).isEmpty()).isTrue();
}
}

@Test
public void testConfigNullField() {
try(ValidatorFactory factory = Validation.buildDefaultValidatorFactory()) {
Validator validator = factory.getValidator();

Config config = new Config();
Set<ConstraintViolation<Config>> validate = validator.validate(config);

assertThat(validate.isEmpty()).isFalse();
assertThat(validate.size()).isEqualTo(2);
}
}

}
Loading
Loading