Skip to content

lower visibility of method ( main ) #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

lower visibility of method ( main ) #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5b4d7
lower visibility of method
wind57 Sep 25, 2025
07987d5
Merge branch 'main' into lower-visibility-of-method
wind57 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ain/java/org/springframework/cloud/kubernetes/commons/config/reload/ConfigReloadUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ public static boolean reload(PropertySourceLocator locator, ConfigurableEnvironm
* @return finds all registered property sources of the given type
* @deprecated this method will not be public in the next major release.
*/
@Deprecated(forRemoval = false)
Copy link
Contributor Author

@wind57 wind57 Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowers the visibility of this method: it is needed because reasoning about the code becomes far easier here.

public static <S extends PropertySource<?>> List<S> findPropertySources(Class<S> sourceClass,
static <S extends PropertySource<?>> List<S> findPropertySources(Class<S> sourceClass,
ConfigurableEnvironment environment) {
List<S> managedSources = new ArrayList<>();

Expand Down
80 changes: 0 additions & 80 deletions ...framework/cloud/kubernetes/fabric8/config/EventBasedConfigurationChangeDetectorTests.java
View file
Open in desktop

This file was deleted.

Loading