Replace Collectors.toList() with Stream.toList() #1747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eunseo9311
force-pushed
the
refactor/replace-collectors-tolist
branch
from
095df0b to
08769cc
Compare
Contributor
|
The build is currently failing. You can run it locally with |
mhalbritter
added
the
status: waiting-for-feedback
eunseo9311
force-pushed
the
refactor/replace-collectors-tolist
branch
from
08769cc to
6c4cb6e
Compare
Modernize stream collection operations by replacing Collectors.toList() with Stream.toList() introduced in Java 16. Changes: - 17 files updated across multiple modules - Removed unused Collectors import statements where applicable - Retained Collectors import where joining() or toCollection() is used Motivation: - Conciseness: stream.toList() is shorter and more readable - Performance: Avoids creating an intermediate Collector object - Immutability: toList() returns an unmodifiable list - Modern Java: Aligns with Java 16+ idioms since the project requires Java 17 Signed-off-by: Eunseo Song <[email protected]>
eunseo9311
force-pushed
the
refactor/replace-collectors-tolist
branch
from
6c4cb6e to
64081a3
Compare
Contributor
Author
|
I've fixed the formatting issues and force-pushed. The build should pass now. |
spring-projects-issues
added
status: feedback-provided
mhalbritter
added
type: task
and removed
status: feedback-provided
mhalbritter
pushed a commit
that referenced
this pull request
Jan 28, 2026
See gh-1747 Signed-off-by: Eunseo Song <[email protected]>
mhalbritter
added a commit
that referenced
this pull request
Jan 28, 2026
Contributor
|
Thanks @eunseo9311 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Replace Collectors.toList() with Stream.toList()
Summary
Modernize stream collection operations by replacing
Collectors.toList()withStream.toList()introduced in Java 16.Changes
Collectorsimport statements where applicableCollectorsimport wherejoining()ortoCollection()is still usedMotivation
stream.toList()is shorter and more readabletoList()returns an unmodifiable list