Fix JsonReader parallel issue #1396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with parallel stream used in
JsonReader.Problem
I wrote a simple program to test the
JsonReader. The JSON content is very simple.[ { "name": "Alex", "email": "[email protected]", "jobTitle": "Software Engineer" }, { "name": "Bob", "email": "[email protected]", "jobTitle": "System Admin" } ]The code shown below extracts keys
nameandjobTitleand puts them into theDocument.When running this simple program, the output may look like below. The text of keys and values from different keys are mingled (
jobTitle: name: System AdminBob).The usage of
parallelStreamcaused the invocations ofStringBuffer.appendfor different keys from different threads intertwined when operating on the sharedStringBuffer.Fix
The parallel processing of multiple keys seems unnecessary, since parallel processing is already enabled for documents in the JSON array, and we are dealing with only in-memory data. So I changed to use normal stream and replaced
StringBufferwithStringBuilder.