Skip to content

Fix JsonReader parallel issue #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix JsonReader parallel issue #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spring-ai-core/src/main/java/org/springframework/ai/reader/JsonReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@
*/
public class JsonReader implements DocumentReader {

private Resource resource;
private final Resource resource;

private JsonMetadataGenerator jsonMetadataGenerator;
private final JsonMetadataGenerator jsonMetadataGenerator;

private final ObjectMapper objectMapper = new ObjectMapper();

/**
* The key from the JSON that we will use as the text to parse into the Document text
*/
private List<String> jsonKeysToUse;
private final List<String> jsonKeysToUse;

public JsonReader(Resource resource) {
this(resource, new ArrayList<>().toArray(new String[0]));
this(resource, new String[0]);
}

public JsonReader(Resource resource, String... jsonKeysToUse) {
Expand Down Expand Up @@ -92,9 +92,9 @@ public List<Document> get() {
private Document parseJsonNode(JsonNode jsonNode, ObjectMapper objectMapper) {
Map<String, Object> item = objectMapper.convertValue(jsonNode, new TypeReference<Map<String, Object>>() {
});
StringBuffer sb = new StringBuffer();
var sb = new StringBuilder();

jsonKeysToUse.parallelStream().filter(item::containsKey).forEach(key -> {
jsonKeysToUse.stream().filter(item::containsKey).forEach(key -> {
sb.append(key).append(": ").append(item.get(key)).append(System.lineSeparator());
});

Expand Down