GH-1623 fix typo for updating node in Neo4jVectorStore #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitokim
changed the title
Define DEFAULT_TRANSACTION_SIZE for the hardcoded batch size in the delete query Signed-off-by: jitokim <[email protected]>
jitokim
force-pushed
the
gh-1623-fix-neo4j-query
branch
from
2f9e69d to
885b397
Compare
|
Hi @michael-simons , can you please review this PR? |
michael-simons
approved these changes
Nov 4, 2024
...spring-ai-neo4j-store/src/main/java/org/springframework/ai/vectorstore/Neo4jVectorStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jitokim <[email protected]>
|
@michael-simons thanks for review 😀 |
|
thanks for the contribution and the review! merged in 1cdec7b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.