Skip to content

GH-1623 fix typo for updating node in Neo4jVectorStore #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

GH-1623 fix typo for updating node in Neo4jVectorStore #1635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885b397
GH-1623 fix typo for adding document in Neo4jVectorStore
jitokim Oct 30, 2024
1471dca
Applied the suggested change
jitokim Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...ing-ai-neo4j-store/src/main/java/org/springframework/ai/vectorstore/Neo4jVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,14 @@
* @author Christian Tzolov
* @author Thomas Vitale
* @author Soby Chacko
* @author Jihoon Kim
*/
public class Neo4jVectorStore extends AbstractObservationVectorStore implements InitializingBean {

public static final int DEFAULT_EMBEDDING_DIMENSION = 1536;

public static final int DEFAULT_TRANSACTION_SIZE = 10_000;

public static final String DEFAULT_LABEL = "Document";

public static final String DEFAULT_INDEX_NAME = "spring-ai-document-index";
Expand Down Expand Up @@ -117,7 +120,7 @@ public void doAdd(List<Document> documents) {
SET u.%2$s = row.id,
u += row.properties
WITH row, u
CALL db.create.setNodeVectorProperty(u, $embeddingProperty, row.embedding)
CALL db.create.setNodeVectorProperty(u, $embeddingProperty, row[$embeddingProperty])
""".formatted(this.config.label, this.config.idProperty);
session.run(statement, Map.of("rows", rows, "embeddingProperty", this.config.embeddingProperty)).consume();
}
Expand All @@ -133,7 +136,7 @@ public Optional<Boolean> doDelete(List<String> idList) {
MATCH (n:%s) WHERE n.%s IN $ids
CALL { WITH n DETACH DELETE n } IN TRANSACTIONS OF $transactionSize ROWS
""".formatted(this.config.label, this.config.idProperty),
Map.of("ids", idList, "transactionSize", 10_000))
Map.of("ids", idList, "transactionSize", DEFAULT_TRANSACTION_SIZE))
.consume();
return Optional.of(idList.size() == summary.counters().nodesDeleted());
}
Expand Down