Neo4j module: remove unnecessary property removal. #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projects#1932 Signed-off-by: Gerrit Meier <[email protected]>
| UNWIND $rows AS row | ||
| MERGE (u:%s {%2$s: row.id}) | ||
| ON CREATE | ||
| SET u += row.properties |
There was a problem hiding this comment.
I am nitpicking, but please consider modifying line 211 so that the SET statement is right under MERGE
Contributor
Author
There was a problem hiding this comment.
Nitpicking back 😄 The set operation is a follow-up operation on the merge and therefore I would prefer to keep it indented for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boils down the create or update logic even more.
Closes #1932