Fix NPE when metadata is null in MilvusVectorStore #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please address the DCO commit signing. https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring |
Signed-off-by: little_huang <[email protected]>
Contributor
Author
Thanks, @sobychacko — signed off and force-pushed. DCO is green now. |
spring-builds
pushed a commit
that referenced
this pull request
Aug 14, 2025
Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash. Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline. Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata. Fixes #4115 Signed-off-by: little_huang <[email protected]> (cherry picked from commit 1e28e30)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
) Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash. Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline. Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata. Fixes spring-projects#4115 Auto-cherry-pick to 1.0.x Signed-off-by: little_huang <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
) Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash. Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline. Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata. Fixes spring-projects#4115 Auto-cherry-pick to 1.0.x Signed-off-by: little_huang <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
) Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash. Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline. Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata. Fixes spring-projects#4115 Auto-cherry-pick to 1.0.x Signed-off-by: little_huang <[email protected]> Signed-off-by: 家娃 <[email protected]>
ralla0405
pushed a commit
to ralla0405/spring-ai
that referenced
this pull request
Nov 28, 2025
) Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash. Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline. Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata. Fixes spring-projects#4115 Auto-cherry-pick to 1.0.x Signed-off-by: little_huang <[email protected]> Signed-off-by: logan-mac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Guard against NPE when metadata is null during distance injection
Description
Adds a null check before injecting the distance property into metadata to prevent a NullPointerException if metadata is missing from the row record. The change is intentionally minimal and does not alter existing behavior beyond avoiding the crash.
Motivation / Background
Some search results do not carry metadata (or the metadata value is null). Calling JsonObject.addProperty(...) on a null reference throws an NPE and breaks the mapping pipeline.
Changes
Add a null guard around the distance injection step to ensure we do not call addProperty(...) on a null metadata.
Behavior
No functional changes other than preventing the NPE when metadata is null.
Related issues
Fixes #4115