Skip to content

Fix NPE when metadata is null in MilvusVectorStore #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobychacko merged 1 commit into from
Aug 14, 2025
Merged

Fix NPE when metadata is null in MilvusVectorStore #4116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...lvus-store/src/main/java/org/springframework/ai/vectorstore/milvus/MilvusVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,10 @@ public List<Document> doSimilaritySearch(SearchRequest request) {
JsonObject metadata = new JsonObject();
try {
metadata = (JsonObject) rowRecord.get(this.metadataFieldName);
// inject the distance into the metadata.
metadata.addProperty(DocumentMetadata.DISTANCE.value(), 1 - getResultSimilarity(rowRecord));
if (metadata != null) {
// inject the distance into the metadata.
metadata.addProperty(DocumentMetadata.DISTANCE.value(), 1 - getResultSimilarity(rowRecord));
}
}
catch (ParamException e) {
// skip the ParamException if metadata doesn't exist for the custom
Expand Down