Polish Collection field initialization in @ConfigurationProperties classes #43933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses 1. avoid adding elements to immutable Collection, see https://github.com/spring-projects/spring-boot/blob/91da8c56a2bdcb54d0ae9b2e696d45a3d2819f96/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/CollectionBinder.java#L66-L68 2. use `List.of()` instead of `Arrays.asList()` Signed-off-by: Yanming Zhou <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
This was already declined by a team member. What are you expecting? |
bclozel
added
status: declined
The changes by this PR is not same as @wilkinsona declined, please read the description then give your advices. |
|
This is the change that was suggested as an alternative on #43918 and that I said was not worth it. Please don’t waste the team’s time by then opening a PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/CollectionBinder.java
Lines 66 to 68 in 91da8c5
List.of()instead ofArrays.asList()