Skip to content

Polish Collection field initialization in @ConfigurationProperties classes #43933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish Collection field initialization in @ConfigurationProperties classes #43933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...c/main/java/org/springframework/boot/actuate/autoconfigure/tracing/TracingProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2024 the original author or authors.
* Copyright 2012-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -199,12 +199,12 @@ public static class Propagation {
/**
* Tracing context propagation types produced by the application.
*/
private List<PropagationType> produce = List.of(PropagationType.W3C);
private List<PropagationType> produce = new ArrayList<>(List.of(PropagationType.W3C));

/**
* Tracing context propagation types consumed by the application.
*/
private List<PropagationType> consume = List.of(PropagationType.values());
private List<PropagationType> consume = new ArrayList<>(List.of(PropagationType.values()));

public void setType(List<PropagationType> type) {
this.type = type;
Expand Down
5 changes: 2 additions & 3 deletions ...nfigure/src/main/java/org/springframework/boot/autoconfigure/quartz/QuartzProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2021 the original author or authors.
* Copyright 2012-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,7 +18,6 @@

import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -155,7 +154,7 @@ public static class Jdbc {
/**
* Prefixes for single-line comments in SQL initialization scripts.
*/
private List<String> commentPrefix = new ArrayList<>(Arrays.asList("#", "--"));
private List<String> commentPrefix = new ArrayList<>(List.of("#", "--"));

public String getSchema() {
return this.schema;
Expand Down
3 changes: 1 addition & 2 deletions ...framework/boot/autoconfigure/security/oauth2/resource/OAuth2ResourceServerProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import java.io.InputStream;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

import org.springframework.boot.context.properties.ConfigurationProperties;
Expand Down Expand Up @@ -62,7 +61,7 @@ public static class Jwt {
/**
* JSON Web Algorithms used for verifying the digital signatures.
*/
private List<String> jwsAlgorithms = Arrays.asList("RS256");
private List<String> jwsAlgorithms = new ArrayList<>(List.of("RS256"));

/**
* URI that can either be an OpenID Connect discovery endpoint or an OAuth 2.0
Expand Down
5 changes: 2 additions & 3 deletions ...igure/src/main/java/org/springframework/boot/autoconfigure/session/SessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -18,7 +18,6 @@

import java.time.Duration;
import java.time.temporal.ChronoUnit;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
import java.util.function.Supplier;
Expand Down Expand Up @@ -88,7 +87,7 @@ public static class Servlet {
* Session repository filter dispatcher types.
*/
private Set<DispatcherType> filterDispatcherTypes = new HashSet<>(
Arrays.asList(DispatcherType.ASYNC, DispatcherType.ERROR, DispatcherType.REQUEST));
Set.of(DispatcherType.ASYNC, DispatcherType.ERROR, DispatcherType.REQUEST));

public int getFilterOrder() {
return this.filterOrder;
Expand Down
5 changes: 2 additions & 3 deletions ...rationmetadata/annotationprocessor/automaticmetadatageneration/MyMessagingProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2021 the original author or authors.
* Copyright 2012-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -17,15 +17,14 @@
package org.springframework.boot.docs.appendix.configurationmetadata.annotationprocessor.automaticmetadatageneration;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

import org.springframework.boot.context.properties.ConfigurationProperties;

@ConfigurationProperties(prefix = "my.messaging")
public class MyMessagingProperties {

private List<String> addresses = new ArrayList<>(Arrays.asList("a", "b"));
private List<String> addresses = new ArrayList<>(List.of("a", "b"));

private ContainerType containerType = ContainerType.SIMPLE;

Expand Down
Loading