Skip to content

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 4, 2025

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 4, 2025
@nosan
Copy link
Contributor Author

nosan commented Feb 4, 2025

Now, ElasticsearchContainerConnectionDetailsFactoryTests fails due to:


node: http://localhost:65055/, status: 200, [es/cluster.health] Failed to decode response
co.elastic.clients.transport.TransportException: node: http://localhost:65055/, status: 200, [es/cluster.health] Failed to decode response
	at co.elastic.clients.transport.ElasticsearchTransportBase.decodeTransportResponse(ElasticsearchTransportBase.java:409)
	at co.elastic.clients.transport.ElasticsearchTransportBase.getApiResponse(ElasticsearchTransportBase.java:367)
	at co.elastic.clients.transport.ElasticsearchTransportBase.performRequest(ElasticsearchTransportBase.java:148)
	at co.elastic.clients.elasticsearch.cluster.ElasticsearchClusterClient.health(ElasticsearchClusterClient.java:439)
	at org.springframework.boot.testcontainers.service.connection.elasticsearch.ElasticsearchContainerConnectionDetailsFactoryTests.connectionCanBeMadeToElasticsearchContainer(ElasticsearchContainerConnectionDetailsFactoryTests.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'HealthResponse.unassignedPrimaryShards'
	at co.elastic.clients.util.ApiTypeHelper.requireNonNull(ApiTypeHelper.java:76)

@nosan
Copy link
Contributor Author

nosan commented Feb 5, 2025

I had to update TestImage.ELASTICSEARCH_8 version to 8.17.1.

elastic/elasticsearch-java#919

@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 5, 2025
@philwebb philwebb added this to the 3.5.x milestone Feb 5, 2025
@wilkinsona
Copy link
Member

I think this needs to wait until we're on a Spring Data snapshot where they've made a similar upgrade (see #43669).

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Feb 5, 2025
@wilkinsona wilkinsona self-assigned this Feb 7, 2025
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Feb 7, 2025
@wilkinsona wilkinsona changed the title Upgrade to Elasticsearch Client 8.17.1 Upgrade to Elasticsearch Client 8.17.0 Feb 7, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.0-M2 Feb 8, 2025
wilkinsona pushed a commit that referenced this pull request Feb 8, 2025
wilkinsona added a commit that referenced this pull request Feb 8, 2025
@wilkinsona wilkinsona closed this in 17336d2 Feb 8, 2025
@wilkinsona
Copy link
Member

Thanks very much, @nosan. I've dropped back to 8.17.0 for now so that we're aligned with Spring Data Elasticsearch.

@nosan
Copy link
Contributor Author

nosan commented Feb 8, 2025

Thanks, @wilkinsona

@wilkinsona wilkinsona added type: task A general task status: superseded An issue that has been superseded by another and removed type: dependency-upgrade A dependency upgrade labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants